Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini product card #1567

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Mini product card #1567

merged 2 commits into from
Mar 20, 2024

Conversation

BaskarMitrah
Copy link
Collaborator

Description

Added Mini Product Resources card, added video in the Hero Block, modified the design in accordion

Copy link
Collaborator

@timkim timkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr looks fine but there's an error with the smoke test. Looks like one of the pages is taking too long to respond. I wonder if it's because of the embedded video not running in the test suite

@timkim
Copy link
Collaborator

timkim commented Mar 20, 2024

Oh I think the e2e is failing due to something else. Merging!

@timkim timkim merged commit 8cdcc61 into main Mar 20, 2024
2 of 3 checks passed
@timkim timkim deleted the mini_product_card branch March 20, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants