build:added some design issue #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Baskar! |
timkim
pushed a commit
that referenced
this pull request
May 20, 2024
timkim
added a commit
that referenced
this pull request
Jul 24, 2024
* build : Initial commit for get credential phase 2 * build : --Added the separated components and moved into folder * build : --Updated the get crdential external page * feat: wired up get template by id and install template endpoints (#1577) * feat: wired up get template by id and install template endpoints * fix: remove unused code * Delete yarn.lock --------- Co-authored-by: BaskarMitrah <113968869+BaskarMitrah@users.noreply.github.com> * fix: added request access * integrated request access * build : Fixed design issues & Removed unwanted code * fix: code improvements * build : fixed the design issues and removed the unwanted code * Revert "build : fixed the design issues and removed the unwanted code" This reverts commit 07751e0. * build:added some design issue (#1580) * fix: incorrect import * build: update change organization * fix: build issue * Add back in yarn.lock * Increase cypress timeout * Increase cypress timeout again * added hardcoded wiring for generating access token * build : showed access token and secret key in the card * Added optional chaining to the response * fix: oauths2s and api key get credential components * --Fixed bugs * fix : reduced code & added tooltip for card * fix : removed unwanted code * feat: bug fix, integrate with TR on stage * fix: fixes * Bugs/api integration (#1581) * build : api integration & fixed design issue * build : added edge cases * -- Wired edge case in the RequestAccess * fix: access token generation * fix: show scrollbar * fix: reorder error case handling * fix: remove type1 edge case for api key credential * Added allowed origins, Changed the building blocks for Restrictedaccessproducts * Fixed the issue in download * fix: do not check for org type in index.js --------- Co-authored-by: BaskarMitrah <mit44186@adobe.com> Co-authored-by: Manimaran Kottursamy <mit80447@adobe.com> * fix: increase cypress timeout * fix : Added Scopes & fixed design issues (#1583) Co-authored-by: BaskarMitrah <mit44186@adobe.com> * feat: integrated the new accounts API, bug fixes * fix: code improvements and bug fixes * removed unnecessary console.log * feat: use window.adobeIMS instead of ims from context * Bugs/remaned components (#1584) * -- Removed the Subscription Error * renamed NestedAlertContent files * --Fixed Sample code download issues * --fixed the project link to the card after create the credential * --Fixed the checkmark issues on the picker in the return flow project details * Fixed scopes details as dynamic * --Separated the Service and formfields page --------- Co-authored-by: BaskarMitrah <mit44186@adobe.com> Co-authored-by: Manimaran Kottursamy <mit80447@adobe.com> * test: added e2e tests for get credentials * test: added console logs * test: run get credentials along with smoke tests * test: try running tests on https * test: try running tests on https * test: added basic login test for get credentials component * test: added get_credential_phase2 to pr test branches * test: try pass env vars to the start command * test: force trigger tests * test: revert force trigger * fix: env vars * test: create env file in git * test: enable running tests for PRs to get_credential_phase2 * --Added the test for the credential for oAuth & APIKey * Migrated the functionalities from commands to get-credentials.cy * --Migrated to commands to functions * removed unnecessary wait and reorganized code * disable videos, increase command timeout * test improvements * added form submission test * comment out get credentials e2e test * do not run e2e tests for get_credential_phase2 * fix: test * test: enable get creds test, run on self-hosted runner * fix: added step to install yarn * test: try installing yarn as root * fix: run test commands as root * fix: try using npx to run yarn commands * fix: run install command as root, upgrade to cypress gh action v6 * feat: added step to install latest lts version of node * try print node version * try adding cache and cache-dependency-path * fix: format * remove caching * print node version * print non-sudo node version * try installing yarn without sudo * do not use sudo, enable caching of yarn packages * revert to use cypress github action v5 * try running in docker * use checkout v4 * debug missing checkout step files * add sudo to ls * run id * try using user root * remove sudo * remove id * added custom certs for e2e tests * remove build step, increase wait timeout * remove unnecessary code * remove extra file --------- Co-authored-by: BaskarMitrah <mit44186@adobe.com> Co-authored-by: BaskarMitrah <113968869+BaskarMitrah@users.noreply.github.com> Co-authored-by: timkim <timk@adobe.com> Co-authored-by: Manimaran Kottursamy <mit80447@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: