Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to enable Greenkeeper 🌴 #21

Closed
wants to merge 2 commits into from

Conversation

greenkeeper[bot]
Copy link

@greenkeeper greenkeeper bot commented Dec 11, 2019

Closes #22

Let’s get started with automated dependency management for aio-tvm 💪

This pull request updates all your dependencies to their latest version. Having them all up to date really is the best starting point for keeping up with new releases. Greenkeeper will look out for further dependency updates and make sure to handle them in isolation and in real-time, but only after you merge this pull request.

Important: Greenkeeper will only start watching this repository’s dependency updates after you merge this initial pull request.


💥 Tests on this branch are failing. Here’s how to proceed.

To solve the issue, first find out which of the dependency’s updates is causing the problem. Then fix your code to accomodate the changes in the updated dependency. next-update is a really handy tool to help you with this.

Then push your changes to this branch and merge it.

🏷 How to check the status of this repository

Greenkeeper adds a badge to your README which indicates the status of this repository.

This is what your badge looks like right now 👉 Greenkeeper badge

🙈 How to ignore certain dependencies

You may have good reasons for not wanting to update to a certain dependency right now. In this case, you can change the dependency’s version string in the package.json file back to whatever you prefer.

To make sure Greenkeeper doesn’t nag you again on the next update, add a greenkeeper.ignore field to your package.json, containing a list of dependencies you don’t want to update.

// package.json
{
  
  "greenkeeper": {
    "ignore": [
      "package-names",
      "you-want-me-to-ignore"
    ]
  }
}
👩‍💻 How to update this pull request
  # Change into your repository’s directory
  git fetch --all
  git checkout greenkeeper/initial
  npm install-test
  # Adapt your code until everything works again
  git commit -m 'chore: adapt code to updated dependencies'
  git push https://github.com/adobe/aio-tvm.git greenkeeper/initial
✨ How do dependency updates work with Greenkeeper?

After you merge this pull request, Greenkeeper will create a new branch whenever a dependency is updated, with the new version applied. The branch creation should trigger your testing services and check whether your code still works with the new dependency version. Depending on the the results of these tests Greenkeeper will try to open meaningful and helpful pull requests and issues, so your dependencies remain working and up-to-date.

-  "underscore": "^1.6.0"
+  "underscore": "^1.7.0"

The above example shows an in-range update. 1.7.0 is included in the old ^1.6.0 range, because of the caret ^ character .
When the test services report success Greenkeeper will silently delete the branch again, because no action needs to be taken – everything is fine.

However, should the tests fail, Greenkeeper will create an issue to inform you about the problem immediately.

This way, you’ll never be surprised by a dependency breaking your code. As long as everything still works, Greenkeeper will stay out of your way, and as soon as something goes wrong, you’ll be the first to know.

-  "lodash": "^3.0.0"
+  "lodash": "^4.0.0"

In this example, the new version 4.0.0 is not included in the old ^3.0.0 range.
For version updates like these – let’s call them “out of range” updates – you’ll receive a pull request.

This means that you no longer need to check for new versions manually – Greenkeeper will keep you up to date automatically.

These pull requests not only serve as reminders to update: If you have solid tests and good coverage, and the pull requests passes those tests, you can very likely just merge it and release a new version of your software straight away :shipit:

To get a better idea of which ranges apply to which releases, check out the extremely useful semver calculator provided by npm.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Good luck with your project and see you soon ✨

Your Greenkeeper bot 🌴

@shazron
Copy link
Member

shazron commented Dec 12, 2019

@moritzraho with the upgrade to the new azure versions (major versions) there are test failures:

TypeError: Cannot set property 'newPipeline' of undefined

      20 |
      21 | azure.SharedKeyCredential = jest.fn()
    > 22 | azure.StorageURL.newPipeline = jest.fn()
         | ^
      23 | azure.ServiceURL = jest.fn()
      24 | azure.ContainerURL.fromServiceURL = jest.fn().mockReturnValue({
      25 |   create: azureContainerCreateMock
at Object.<anonymous> (test/unit/lib/impl/AzureBlobTvm.test.js:22:1)

I figure you will encounter this problem soon, so FYI
https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob/ChangeLog.md

@shazron
Copy link
Member

shazron commented Dec 12, 2019

These lines have undefined exceptions:

  1. azure.StorageURL.newPipeline = jest.fn()
  2. azure.ContainerURL.fromServiceURL = jest.fn().mockReturnValue({
    create: azureContainerCreateMock
    })
  3. azure.generateBlobSASQueryParameters = jest.fn()

@moritzraho
Copy link
Member

@shazron thanks for the details. I would be careful at updating major versions even if we fix this it might introduce more subtle bugs, wdyt should we delay a bit more and do it properly?

@greenkeeper
Copy link
Author

greenkeeper bot commented Dec 19, 2019

Hey there 👋,

we noticed that this PR isn’t merged yet. Just to let you know: if you don't merge this PR, Greenkeeper will not be enabled on this repo, and you won't receive updates for your dependencies.

If you don't want to enable Greenkeeper here, just close or ignore this PR, we won't nag you again. ✌️

Have a great day! 🌴

@moritzraho
Copy link
Member

closing this now, and opening an issue as we have to proceed with caution for updates in the tvm

@moritzraho moritzraho closed this Apr 21, 2020
@moritzraho
Copy link
Member

actually my bad #22 has already been raised by @shazron

@greenkeeper greenkeeper bot deleted the greenkeeper/initial branch May 29, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies: With upgrade to @azure/storage-blob@12, tests don't pass
2 participants