This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Send binary Brackets-Node command responses #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Reviewed. Merging. |
jasonsanjose
added a commit
that referenced
this pull request
Jan 9, 2014
Send binary Brackets-Node command responses
jasonsanjose
added a commit
that referenced
this pull request
Dec 8, 2015
Send binary Brackets-Node command responses
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Brackets-Node
ConnectionManagerso that it can send binary responses to commands in Node domains without additional encoding.When a command responds with an object that is an instance of a Node
Buffer, theConnectionManagerassumes that the response should be sent via the WebSocket using a binary message. To do so, it encodes the (32-bit unsigned integer) command ID as a four-byte header, which is prepended to the command's result Buffer as the final response message.For now, the only binary messages that can be sent are of type
"commandResponse".This should be reviewed in tandem with a companion brackets pull request, adobe/brackets#6339, which updates
NodeConnectionto receive these binary command responses.