Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Fix full screen window issue in multiple montiors #638

Merged
merged 2 commits into from
Apr 13, 2018

Conversation

sobisht
Copy link
Collaborator

@sobisht sobisht commented Apr 13, 2018

Issue: adobe/brackets#13349

  • Currently we are not handling the WM_NCPAINT for dark aero glass. This causes the issue when we delegate this handling to the OS.
    To fix this issue, I have added a handle for dark aero similar to the one present for dark window.

  • This will also fix the following issue
    brackets

The boundaries of the non client area is not correctly painted when we launch brackets in maximized window and go from maximize to restored window.
After the fix
brackets_fix

Unit tested the fix

  • On Win10 builds before and after creators update.
  • On Dual monitors with different resolution
  • On Dual monitors with one monitor with high DPI.

Please review @nethip @swmitra @vickramdhawal @JeffryBooher

@nethip
Copy link
Contributor

nethip commented Apr 13, 2018

Thanks for the PR @sobisht . Great work!

I see that these are also not handled inside cef_aero_dark_window. Does it make sense to handle the following as well?

WM_NCCREATE
WM_NCDESTROY
WM_NCHITTEST

@sobisht
Copy link
Collaborator Author

sobisht commented Apr 13, 2018

@nethip

  • We are already handling WM_NCHITTEST in cef_dark_aero_window::DwpCustomFrameProc().
  • The functionality related to WM_NCCREATE is done by HandleCreate() for WM_CREATE. On adding the handling of WM_NCCREATE introduces the issue again.
  • And WM_NCDESTROY is handled by cef_window::WindowProc() called in cef_dark_aero_window::WindowProc().

So explicit handling of this messages might not be required.

@nethip
Copy link
Contributor

nethip commented Apr 13, 2018

Thanks for confirming @sobisht!

@nethip nethip merged commit 964cafd into adobe:master Apr 13, 2018
@nethip
Copy link
Contributor

nethip commented Apr 13, 2018

Thanks for fixing this @sobisht

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants