Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

first draft of sprint 34 updates #96

Merged
merged 3 commits into from
Nov 11, 2013
Merged

Conversation

jasonsanjose
Copy link
Member

No description provided.

"downloadURL": "http://download.brackets.io",
"newFeatures": [
{
"name": "Upradable Installer",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "Upgradable"... though I wonder if that's clear enough. Maybe something like "Install Updates in Place"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw @bchintx did we ever write up documentation for how to have two versions installed at once, if needed for testing? (I'd thought that was one of the story tasks, but looks like I was wrong)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in-place" seems maybe a bit technical? Upgrade Brackets Installation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterflynn Good observation. No, I haven't documented that anywhere, but I can definitely do so. Any suggestions on where to add those steps?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bchintx Maybe just the release notes for now? Could add it to the "UI Changes" section that already mentions upgrade-in-place...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterflynn Great suggestion. Done.

@peterflynn
Copy link
Member

@jasonsanjose Done reviewing -- just a few suggestions.

},
{
"name": "Live Preview Reliability",
"description": "On Mac, launching Chrome is now more reliable and no longer requires Chrome to be restarted."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably replace "restarted" with "relaunched" to match terminology used by dialog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jasonsanjose
Copy link
Member Author

@peterflynn changes pushed.

"downloadURL": "http://download.brackets.io",
"newFeatures": [
{
"name": "Upgrade Brackets Installation",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonsanjose This still seems like it might not be super explanatory to users. What about "Upgrade Existing Brackets Installations"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jasonsanjose
Copy link
Member Author

@peterflynn one more time :)

@peterflynn
Copy link
Member

Looks good -- merging

peterflynn added a commit that referenced this pull request Nov 11, 2013
@peterflynn peterflynn merged commit 4127ee4 into master Nov 11, 2013
@redmunds
Copy link
Contributor

@jbalsas @TomMalbran The en updates for Sprint 34 are complete, so you can start translating for es.

@njx
Copy link
Contributor

njx commented Nov 11, 2013

Drive-by: "effecient" should be "efficient"

@jbalsas
Copy link
Contributor

jbalsas commented Nov 11, 2013

@redmunds was just doing that ;)

},
{
"name": "New and Updated Translations",
"description": "New Dutch and Persian community contributed translations. Updated French, Japanese, Brazilian Portuguese, Czech, Finnish, German, Romanian, Spanish, Swedish and Turkish translations."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I missed it, Romanian is not yet merged, is it? (adobe/brackets#5836).

If we think it'll get done, it should go into the new translations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... actually that one's assigned to me... how did that happen? :D

I'll take care to see if that's ready to merge. Sorry about that!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonsanjose It looks like the Romanian PR would actually be a brand-new language though -- so shouldn't it be listed in the first sentence instead of the second? (Although this also makes me think... if the number of items in the first sentence changes due to some PRs not landing, it may be difficult to change without retranslating -- lists of length 1 and/or 2 can be special cases grammatically in some languages).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get both strings translated with and without romanian. Since it's after hours and the translations may begin tonight, I'll do this immediately on master.

@jasonsanjose jasonsanjose deleted the jasonsanjose/sprint34 branch November 11, 2013 23:19
@jasonsanjose
Copy link
Member Author

@njx fixed directly on master. Thanks for catching that.

@jbalsas Right, Romanian, Swedish and Turkish aren't merged yet. If they don't land, we'll update the english and translated notifications to remove them.

@RaymondLim
Copy link

@jasonsanjose
My pull request adobe/brackets#5944 for image tip landed in master today. Should we mention it also? We're now showing the pixel info in the tip and also tracking mouse movement with two crossing guides.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants