Merge pull request #18 from zaggino/marcel/links-external

Open links in an external browser
adobe · May 6, 2015 · af24755 · af24755
2 parents fed5312 + 265c593
commit af24755
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app/appshell/app.js b/app/appshell/app.js
@@ -8,6 +8,7 @@ var utils = require("../utils");
 var remote = require("remote");
 var electronApp = remote.require("app");
 var Menu = remote.require("menu");
+var shell = remote.require("shell");
 var shellState = remote.require("./shell-state");
 
 var menuTemplate = [];
@@ -230,8 +231,8 @@ app.openLiveBrowser = function (url, enableRemoteDebugging, callback) {
 };
 
 app.openURLInDefaultBrowser = function (url, callback) {
-    // TODO: implement
-    callback(new Error("app.openURLInDefaultBrowser not implemented" + url));
+    shell.openExternal(url);
+    callback(app.NO_ERROR);
 };
 
 app.quit = function () {

diff --git a/src/brackets.js b/src/brackets.js
@@ -415,11 +415,11 @@ define(function (require, exports, module) {
             var node = e.target, url;
             while (node) {
                 if (node.tagName === "A") {
+                    e.preventDefault();
                     url = node.getAttribute("href");
                     if (url && !url.match(/^#/)) {
                         NativeApp.openURLInDefaultBrowser(url);
                     }
-                    e.preventDefault();
                     break;
                 }
                 node = node.parentElement;