Focus lost when switching editors

[njx]

1. Click on a file in the sidebar
2. Select some text and do Cmd-C to copy
3. Click on another file in the sidebar
4. Cmd-V to paste

Result: nothing happens, even though the cursor is blinking. Have to click into the editor in order to set focus before pasting.

[njx]

Pretty sure this is a regression. Marking medium pri.

[njx]

Changing to high priority. It's easy to get Brackets in a bad state after this. For example, after step 4, if you switch out of the app and back into it, sometimes Brackets will switch to showing the previous file, but won't properly update the selected item or the title. (If you have trouble reproing that, let me know and I'll try to find specific steps.)

It looks like this broke in 75e4e90. @jasonsanjose, can you take a look?

[peterflynn]

I worry there may be other regressions related to that change -- I think we have a lot of code that assumes editor switches happen synchronously (i.e. DocumentManager probably assumes that EditorManager is done updating after it's done handling currentDocumentChanged).

Just for the record (since NJ & I were out), the relevant changes seem to be pulls #1765 & #1766.

[peterflynn]

I'm seeing a bunch of other weird glitches that I think are related:

• Clicking the link in the header of an inline editor breaks stuff. The editor content doesn't change, but the selection/titlebar say you've now switched files, and the cursor/focus jump to the full-size editor as if you had navigated to the correct file from the "link."
• Sometimes Ctrl+Tab causes a no-op edit in the file you're switching away from
• Commands that should focus the editor afterward (e.g. Ctrl+F followed by Enter) sometimes don't

[jasonsanjose]

FBNC @njx

[njx]

Looks good at a first glance. Will keep an eye on it as I use Brackets over the next few days.