-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Implement statusbar UI and indentation controls #1766
Conversation
Move EditorManager statusbar indicators from StatusBar module to EditorManager. Refactor HTML and LESS for statusbar styles. Note that indentation controls do not work yet.
Couple of changes:
http://garthdb.github.com/Brackets-UI-Prototypes/status_bar/ |
Also, the currently implementation is slightly tighter than prototype, I would space it out a bit. |
Updated with tooltips, margins and hover changes. |
looks good. Couple more recommendations, sorry I didn't include them before
|
<div id="indent-increment" class="indent-step"></div> | ||
</div> | ||
<div id="busy-indicator">◷</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It bugs me that all of the info in the status bar is flowed into a line of text because every time and data changes, all info to the right (or left depending on which side) of whatever changed shifts a few pixels left or right. I would like to see the text layout using fixed width blocks so nothing ever ever shifts.
We could also try using Source Code Pro (monospace) font, but we'd have to pad leading spaces (i.e. so "1", "10", "100" all use same horizontal space).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #1772
Done with UI review. Still need to look at code. |
@GarthDB Changed border-top to darken @ step-size/2 percent. Added padding. |
Pushed fixes from initial UI review. |
Conflicts: src/editor/EditorManager.js src/widgets/StatusBar.js
Looks good. Merging. |
Implement statusbar UI and indentation controls
Requires focused editor fixes (issue #1257, pull #1765) to work properly.