[CLOSED] Implement statusbar UI and indentation controls

[core-ai-bot]

Issue by jasonsanjose
Thursday Oct 04, 2012 at 05:09 GMT
Originally opened as adobe/brackets#1766

---

Requires focused editor fixes (issue #1257, pull #1765) to work properly.

---

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/1766/commits

[core-ai-bot]

Comment by GarthDB
Thursday Oct 04, 2012 at 17:18 GMT

---

Couple of changes:

• Added title properties to the labels for tooltips explaining the toggle for spaces and tabs
• On hover the spaces/tabs label should underline, but not the width number.

http://garthdb.github.com/Brackets-UI-Prototypes/status_bar/

[core-ai-bot]

Comment by GarthDB
Thursday Oct 04, 2012 at 17:18 GMT

---

Also, the currently implementation is slightly tighter than prototype, I would space it out a bit.

[core-ai-bot]

Comment by jasonsanjose
Thursday Oct 04, 2012 at 18:17 GMT

---

Updated with tooltips, margins and hover changes.

[core-ai-bot]

Comment by GarthDB
Thursday Oct 04, 2012 at 18:28 GMT

---

looks good.

Couple more recommendations, sorry I didn't include them before

1. In an attempt to make the arrows more clickable I added a pixel of padding on each side.
2. The border top is a little dark on the status bar. The prototype uses border-top: 1px solid #E6E6E6;

[core-ai-bot]

Comment by redmunds
Thursday Oct 04, 2012 at 19:35 GMT

---

Done with UI review. Still need to look at code.

[core-ai-bot]

Comment by jasonsanjose
Thursday Oct 04, 2012 at 20:42 GMT

---

@GarthDB Changed border-top to darken@ step-size/2 percent. Added padding.

[core-ai-bot]

Comment by jasonsanjose
Thursday Oct 04, 2012 at 20:43 GMT

---

Pushed fixes from initial UI review.

[core-ai-bot]

Comment by redmunds
Thursday Oct 04, 2012 at 22:42 GMT

---

Looks good. Merging.