Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Quick Open for files can briefly show red erroneously on first use #2608

Closed
njx opened this issue Jan 18, 2013 · 5 comments · Fixed by #3184
Closed

Quick Open for files can briefly show red erroneously on first use #2608

njx opened this issue Jan 18, 2013 · 5 comments · Fixed by #3184
Assignees
Milestone

Comments

@njx
Copy link

njx commented Jan 18, 2013

  1. Launch Brackets
  2. Open the brackets src folder
  3. Hit Cmd-Shift-O, then quickly type "codem"

Result: Until the file list is loaded, the text input background becomes red even though there are actually (eventually) going to be matches in the list, so it's misleading. We shouldn't turn the background red until we've actually loaded the file list and verified that there are no matches.

@ghost ghost assigned dangoor Jan 18, 2013
@njx
Copy link
Author

njx commented Jan 18, 2013

Reviewed. To @dangoor.

@peterflynn
Copy link
Member

See the code at the top of searchFileList()...

@njx
Copy link
Author

njx commented Mar 13, 2013

Bumping this to a medium. I hit this a lot--I'm guessing because when you switch out of the Brackets window and then switch back in, it invalidates the file list cache, so you pretty much always see this, and it's confusing since it makes you think you're not going to get a match.

I tried a simple fix for this awhile ago (waiting for the file list promise to resolve before updating the background of the input) but for some reason it was difficult to get it to work, possibly due to flakiness with the way smart autocomplete works. We really need to replace that component with something more reliable...

@njx
Copy link
Author

njx commented Mar 18, 2013

Proposing this for next sprint (23).

@dangoor
Copy link
Contributor

dangoor commented Mar 18, 2013

Yeah, this is much more noticeable with all of the new files in node_modules.

find node_modules | wc -l
    7218

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants