Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CSS code hints overwrite 1 char too many on current line #2875

Closed
peterflynn opened this issue Feb 15, 2013 · 2 comments
Closed

CSS code hints overwrite 1 char too many on current line #2875

peterflynn opened this issue Feb 15, 2013 · 2 comments
Assignees
Milestone

Comments

@peterflynn
Copy link
Member

  1. Start with this code, all on one line: body {margin:0}
  2. Place the cursor between "0" and "}"
  3. Type ;col
  4. Select 'color' from the code hint popup

Result: "}" is overwritten, so the code is now body {margin:0;color:

Expected: the code is now body {margin:0;color:}

If there are more chars after the "}" they're preserved though... e.g. body {margin:0}div{} -> body {margin:0;color:div{}

@ghost ghost assigned RaymondLim Feb 15, 2013
RaymondLim added a commit that referenced this issue Feb 15, 2013
Fix Issue #2875: CSS code hints overwrite 1 char too many on current line
@RaymondLim
Copy link
Contributor

FBNC to @peterflynn

@ghost ghost assigned peterflynn Feb 15, 2013
@peterflynn
Copy link
Member Author

Looks good! @RaymondLim do you have cycles to add a unit test for this? I feel like this is the sort of thing we could quickly add a regression test for...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants