Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Documents may leak due to listeners left on FileEntry #2961

Closed
peterflynn opened this issue Feb 27, 2013 · 1 comment
Closed

Documents may leak due to listeners left on FileEntry #2961

peterflynn opened this issue Feb 27, 2013 · 1 comment
Assignees
@peterflynn
Labels
fix in progress
Milestone
sprint 21

Comments

@peterflynn
Copy link
Member

See this code review comment: #2844 (comment) (note there is an anchor on that link pointing to the specific comment; GitHub stupidly collapses its display text into just a number)
@ghost ghost assigned DennisKehrig and peterflynn Feb 27, 2013
peterflynn added a commit that referenced this issue Feb 28, 2013
@peterflynn
Fix bug #2961 (Documents may leak due to listeners left on FileEntry) -
47018dc 
Simplify by just directly pinging refcounted documents from
DocumentManager.notifyPathNameChanged(). FileUtils no longer triggers a
"rename" event on FileEntry objects and we no longer have a per-Document
listener.

Also, enable block comments in XML files.
@peterflynn peterflynn mentioned this issue Feb 28, 2013
Merged
peterflynn added a commit that referenced this issue Feb 28, 2013
@peterflynn
Update unit test to account for the #2961 fix. Previously, the test was
8d54418 
emulating rename by doing less than ProjectManager.renameItem() does in the
real world. Due to the memory leak fix, the now need a closer imitation.
@DennisKehrig DennisKehrig mentioned this issue Feb 28, 2013
Merged
@pthiess
Copy link
Contributor

pthiess commented Mar 1, 2013

reviewed, sprint 21

jasonsanjose added a commit that referenced this issue Mar 1, 2013
@jasonsanjose
Merge pull request #3011 from adobe/pflynn/document-listener-leak
a31649d 
Code review responses from #2961
@DennisKehrig DennisKehrig mentioned this issue Mar 11, 2013
Open
@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peterflynn peterflynn

Labels
fix in progress
Projects
None yet
Milestone
sprint 21
Development

No branches or pull requests
4 participants
@jasonsanjose @peterflynn @DennisKehrig @pthiess