Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

StringMatch should boost matches with uppercase letters in query #3263

Closed
njx opened this issue Mar 27, 2013 · 6 comments
Closed

StringMatch should boost matches with uppercase letters in query #3263

njx opened this issue Mar 27, 2013 · 6 comments

Comments

@njx
Copy link
Contributor

njx commented Mar 27, 2013

I was using Quick Open to open "Package.js", and got a lot of higher-ranked hits for "package.json". This is probably not a common case, but it occurred to me that it might be a good idea (and relatively harmless to other use cases) if we give a score boost to an uppercase letter in the query string that matches an uppercase letter in the candidate string (vs. a lowercase letter in the candidate), since if you specifically typed it in uppercase in the query, you probably know it's uppercase in the name you want. (This would have the added bonus of giving an easy way to boost acronym/camel-case searches.)

@ghost ghost assigned dangoor Mar 27, 2013
@njx
Copy link
Contributor Author

njx commented Mar 27, 2013

Low pri to @dangoor

@njx
Copy link
Contributor Author

njx commented Apr 1, 2013

Reviewed.

@dangoor dangoor added this to the Brackets 1.0 milestone Mar 17, 2014
@dangoor
Copy link
Contributor

dangoor commented Mar 17, 2014

This appears to basically be the same as #3971 and #3694

@njx njx modified the milestone: Brackets 1.0 Apr 11, 2014
@njx
Copy link
Contributor Author

njx commented Apr 11, 2014

Removing 1.0 milestone - if this does happen to get fixed by the same fix as #2663 (which is still on the 1.0 list) that's cool, but we don't think this one is necessary for 1.0 by itself.

@JeffryBooher
Copy link
Contributor

@dangoor I followed the steps @njx posted in this issue and #9621 doesn't seem to fix it. The tests I was running worked but now I don't know if they just "worked" for other reasons. Maybe I'm doing it wrong but, when I type Package.js, I get package.json followed by Package.js in the QuickOpen list.

dangoor added a commit that referenced this issue Oct 22, 2014
This change feels more satisfying for #3263.
dangoor added a commit that referenced this issue Oct 22, 2014
This change feels more satisfying for #3263.

Also removes no longer used case match.
@JeffryBooher
Copy link
Contributor

Closing as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants