Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Wrong dialog position when window is resized #5296

Closed
marcelgerber opened this issue Sep 23, 2013 · 8 comments
Closed

Wrong dialog position when window is resized #5296

marcelgerber opened this issue Sep 23, 2013 · 8 comments
Assignees
Milestone

Comments

@marcelgerber
Copy link
Contributor

Steps:

  1. Launch brackets
  2. Resize the window to a smaller size (in my case it was 616x418, but thats not as important, just small)
  3. Show a dialog (in my example I pressed the live preview thunderbolt in a .js-file)

This also happens if you first open the dialog and then resize the window.

Results:
The dialog isn't shown fully, although there would be enough space for it (see screen below).
image

Expected:
The dialog is fully visible.
See screen (I've changed the position in the developer tools)
image

ENV: Windows 8 German
Build: 0.30.0-9116 (On branch master,master 60dc6b7)

@peterflynn
Copy link
Member

I think this is a FOL with Bootstrap dialogs -- although someone mentioned they made some improvements in Bootstrap 3...

@WebsiteDeveloper
Copy link
Contributor

@SAplayer @peterflynn this should be fixed with bootstrap 3.
I'm currently working on porting brackets to bootstrap 3

@ghost ghost assigned redmunds Sep 30, 2013
@njx
Copy link

njx commented Sep 30, 2013

Reviewed, to @redmunds

@dangoor
Copy link
Contributor

dangoor commented Sep 30, 2013

To follow up on our approach here: we've decided that we're not going to go forward with an upgrade to Bootstrap 3, which means that we'll be fixing this with our own code.

@WebsiteDeveloper
Copy link
Contributor

@dangoor @redmunds i would like to take a stab at this since i'm familiar with modal dialog code and less

@redmunds
Copy link
Contributor

@WebsiteDeveloper It's all yours. Let me know when you submit a pull request so I can review it.

@marcelgerber
Copy link
Contributor Author

@redmunds
Copy link
Contributor

Confirmed. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants