[CLOSED] Wrong dialog position when window is resized

[core-ai-bot]

Issue by MarcelGerber
Monday Sep 23, 2013 at 18:15 GMT
Originally opened as adobe/brackets#5296

---

Steps:

1. Launch brackets
2. Resize the window to a smaller size (in my case it was 616x418, but thats not as important, just small)
3. Show a dialog (in my example I pressed the live preview thunderbolt in a .js-file)

This also happens if you first open the dialog and then resize the window.

Results:
The dialog isn't shown fully, although there would be enough space for it (see screen below).

Expected:
The dialog is fully visible.
See screen (I've changed the position in the developer tools)

ENV: Windows 8 German
Build: 0.30.0-9116 (On branch master,master 60dc6b72f)

[core-ai-bot]

Comment by peterflynn
Monday Sep 23, 2013 at 19:53 GMT

---

I think this is a FOL with Bootstrap dialogs -- although someone mentioned they made some improvements in Bootstrap 3...

[core-ai-bot]

Comment by WebsiteDeveloper
Monday Sep 23, 2013 at 20:26 GMT

---

@SAPlayer@peterflynn this should be fixed with bootstrap 3.
I'm currently working on porting brackets to bootstrap 3

[core-ai-bot]

Comment by njx
Monday Sep 30, 2013 at 18:09 GMT

---

Reviewed, to@redmunds

[core-ai-bot]

Comment by dangoor
Monday Sep 30, 2013 at 19:09 GMT

---

To follow up on our approach here: we've decided that we're not going to go forward with an upgrade to Bootstrap 3, which means that we'll be fixing this with our own code.

[core-ai-bot]

Comment by WebsiteDeveloper
Monday Sep 30, 2013 at 19:13 GMT

---

@dangoor@redmunds i would like to take a stab at this since i'm familiar with modal dialog code and less

[core-ai-bot]

Comment by redmunds
Monday Sep 30, 2013 at 19:47 GMT

---

@WebsiteDeveloper It's all yours. Let me know when you submit a pull request so I can review it.

[core-ai-bot]

Comment by MarcelGerber
Friday Oct 04, 2013 at 18:35 GMT

---

• fix [CLOSED] [FileSystem] Extension unit tests don't load when using NativeFileSystem #5399

[core-ai-bot]

Comment by redmunds
Thursday Oct 10, 2013 at 00:25 GMT

---

Confirmed. Closing.