Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

One preference manager integration test is failing on Mac #6917

Closed
RaymondLim opened this issue Feb 19, 2014 · 10 comments
Closed

One preference manager integration test is failing on Mac #6917

RaymondLim opened this issue Feb 19, 2014 · 10 comments
Assignees
@dangoor
Labels
fixed but not closed Mac only

Comments

@RaymondLim
Copy link
Contributor

Test case "should find preferences in the project" always fails with "Error: Expected 4 to be 92."
@RaymondLim
Copy link
Contributor Author

Bisect points to this commit e18ebfb.

@dangoor
Copy link
Contributor

dangoor commented Feb 19, 2014

This fails for me on your view-state-migration branch, but not on master. I've run this test quite a bit recently without issue.

@RaymondLim
Copy link
Contributor Author

This actually fails in the master. I noticed it from Jenkins' email notification. And I don't think git bisect lies to me since my branch is not yet merged to the master. Note that this is mac only issue though.

@dangoor
Copy link
Contributor

dangoor commented Feb 19, 2014

Oh, I see. It looks like a difference in timing between the Jenkins machine and mine. The check that it was doing to see that project prefs were loaded would always pass. I just committed a fix in ceea715 that makes sure the correct project prefs are loaded before moving on. We'll see after the jenkins run if that fixes the issue.

Thanks for noticing this!

@dangoor dangoor mentioned this issue Feb 19, 2014
Closed
@dangoor
Copy link
Contributor

dangoor commented Feb 19, 2014

The fix I pushed earlier makes the test pass sometimes, and PR #6925 will likely make the test pass. If it doesn't #6910 will be the real fix for this. I don't want to do #6910 yet, because it may be impacted by #6719

@dangoor
Copy link
Contributor

dangoor commented Feb 20, 2014

I pushed a minor change in 4eb4797 that should make the test resilient to timing differences.

@dangoor
Copy link
Contributor

dangoor commented Feb 20, 2014

Still failing, so it's apparently not a timing issue.

dangoor added a commit that referenced this issue Feb 24, 2014
@dangoor
Fix PreferencesManager test.
57deb81 
This is a fix for #6917. The problem was that
`openAndSelectDocument(nonProjectFile` was being called outside of a `run()`
block, so sometimes the nonProjectFile would be open rather than file that
was supposed to be open.
@dangoor
Copy link
Contributor

dangoor commented Feb 24, 2014

I managed to get this failing sporadically on my machine, and then the problem became obvious to me once i saw which file was open in the test window. 57deb81 should fix this for real.

FBNC to @RaymondLim (and the build server, which I'll keep an eye on 😁)

@RaymondLim
Copy link
Contributor Author

Yes, confirmed that 57deb81 fixed the failing test.

@dangoor
Copy link
Contributor

dangoor commented Feb 24, 2014

Great! And there's been no complaint from the build server, so I'm closing this.

@dangoor dangoor closed this as completed Feb 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dangoor dangoor

Labels
fixed but not closed Mac only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get project settings file loading earlier adobe/brackets
2 participants
@dangoor @RaymondLim