Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Dialogs don't return focus to editor #7511

Open
njx opened this issue Apr 14, 2014 · 5 comments
Open

Dialogs don't return focus to editor #7511

njx opened this issue Apr 14, 2014 · 5 comments

Comments

@njx
Copy link
Contributor

njx commented Apr 14, 2014

  1. Open Extension Manager or File > Project Settings
  2. Click Close or OK
  3. Type something

Result: Does nothing. Focus isn't returned to the editor.

@njx
Copy link
Contributor Author

njx commented Apr 14, 2014

We'll need #7493 (and possibly a wider fix) when fixing this.

@njx
Copy link
Contributor Author

njx commented Apr 21, 2014

Also need to be careful that if you have nested dialogs, it actually returns focus to the previous editor.

@njx
Copy link
Contributor Author

njx commented Apr 21, 2014

Reviewed, low pri to me.

@njx njx self-assigned this Apr 21, 2014
@JeffryBooher
Copy link
Contributor

Here is a pull request that fixed it but there was an outstanding issue which was not addressed so it was closed after several months of inactivity: #4957

@peterflynn
Copy link
Member

@njx You could probably just lift the code from DropdownButton (_lastFocus, etc.) since that already implements the behavior I think we'd want.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants