This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixed editor losing focus (Issue #4954) #4957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -112,6 +113,7 @@ define(function (require, exports, module) { | |||
| showProjectPreferencesDialog(baseUrlValue, result); | |||
| } | |||
| } | |||
| EditorManager.focusEditor(); | |||
There was a problem hiding this comment.
I think this may cause problems if we try to launch the preferences dialog from another dialog. Maybe we should add a check to see if the editor had focus before the dialog was opened before giving focus back to the editor.
We should also add tests to make sure that the focus is restored properly (both to the editor and to another dialog).
|
Closing this as it has become stale. @DaBungalow @RaymondLim commented on this fix so I think we're going to have to fix it int the Modal Dialog code rather than have each dialog blindly give focus back to the editor as this may cause unintended side effects. |
This was referenced Aug 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #4954
This does the quick fix and calls EditorManager.focusEditor().
Tested this on Linux and it works.