Remove min width on image quickview #10364
Conversation
Negative margin has been removed and the height calculated properly using calc()
|
@EJanuszewski you can tag the issues that a pull request addresses by adding #(issue-number), #(issue-number), etc.... That links the issues to the pull request so that it's easy to follow. |
|
@JeffryBooher Ok thanks, hopefully any newer things I do i'll get it right first time, I'm new to referring pulls and issues onto someone elses project. |
|
@EJanuszewski no worries :) |
| @@ -404,6 +403,7 @@ a, img { | |||
|
|
|||
| .image { | |||
| position: relative; | |||
| height: calc(~'100% - 53px'); | |||
There was a problem hiding this comment.
Where does the hardcoded value 53px come from?
|
Are the brackets.less changes intended to be part of this PR? The description at top only mentions #10362... |
|
Sorry I should have put a comment in, 53 is the height of the meta data + its margin(38+15). Fixes for both are just in the brackets.less, it just happened that to fix the chopping off issue also seemed to fix the resizing, hopefully that helps, I'm on my phone so can't type loads. |
Only a small change, seems there's no need for a min-width on the container either.
I have tested with various image sizes and all seem to behave as expected, I will send the pull request shortly.