Implement progress callback so node domains are able to notify the Brackets before they finish #10761
Conversation
|
If we don't want to introduce |
|
@zaggino Sure! I will take a look at this. |
|
The more I'm thinking about this, the more |
|
@zaggino Sorry. I could not find some time to go through this PR as I was caught up with lot of other stuff. I will for sure take a look at this PR next week. |
|
So I'm guessing nobody found time to review this for 1.3 ... |
|
Yes @zaggino That is right. Sorry for not being able to dedicate some time to this PR in this release. |
|
Can we get someone to merge this into 1.4? |
| @@ -192,6 +192,42 @@ define(function (require, exports, module) { | |||
| }); | |||
| }); | |||
|
|
|||
| it("should receive progress events from asynchronous commands", function () { | |||
There was a problem hiding this comment.
@zaggino I ran the Live preview test for Node connection and the test is timing out at should receive progress events from asynchronous commands [win 8.1]. Any idea why?
There was a problem hiding this comment.
@abose Have you taken shell changes also? adobe/brackets-shell#509
There was a problem hiding this comment.
oh! i didn't that explains. Did you verify this change?
Implement progress callback so node domains are able to notify the Brackets before they finish
|
Verified, merging. |
|
This is going to make @zaggino to see this once he is back from vacation 😄 |
|
Thanks a lot guys for merging this 👍 |
Related PR: adobe/brackets-shell#509
Related Issue: #7356
Please review @nethip , I'd like to get this into Brackets as this would help to improve user experience on some of my work I'm doing with extensions.