Toggle panels and no-Distraction mode #11732

abose · 2015-09-23T11:07:15Z

Full code view with all other panels/toolbars hidden.
Also minor refactoring of variable names for toggle/hide for sidebar.
shortcut : ctrl+shift+` for toggle panels
shortcut : ctrl+shift+2 for no distraction mode
Also added panel management API's to workspace manager.

@nethip

Add unit tests

…ore which cannot be satisfied in build tests.

abose · 2015-10-08T10:44:07Z

Should it be hide panels or toggle panels? toggle seems to be troublesome at times.

abose · 2015-10-12T12:26:30Z

@petetnt @ficristo @zaggino

petetnt · 2015-10-12T12:33:11Z

src/extensions/default/NoDistractions/main.js

+    /**
+     * hide all open panels
+     */
+    function _hidePanlesIfRequired() {


Small typo: Panles -> `Panels"

petetnt · 2015-10-12T12:34:58Z

I think that hidePanels should be sufficient, at least until the panels are grouped together with something like #11586. Panels get currently opened and closed all the time so it would be tons of trouble to keep up with their states at this point IMO.

Made a few comments on the code, just some small typos.

The strings use "No distractions" and "Code view only" as the names, should those be unified to one of them?

petetnt · 2015-10-12T12:41:47Z

src/extensions/default/NoDistractions/main.js

+        CMD_TOGGLE_PURE_CODE      = "view.togglePureCode",
+        CMD_TOGGLE_PANELS         = "view.togglePanels";
+
+    //key biding keys


abose · 2015-10-13T10:43:00Z

Thanks @petetnt for reviewing.
Made the change to toggle panel only if workspace has not changed after a hide panels command is issued. This looked intuitive to me.
The documentation for the preference was intentionally worded as Code view only. The string describes what no distractions mode in simple terms.

…fter a hide panels command is issued.

ficristo · 2015-10-14T18:23:05Z

src/utils/Resizer.js

@@ -61,12 +62,13 @@ define(function (require, exports, module) {
    // Load dependent modules
    var AppInit                 = require("utils/AppInit"),
        EventDispatcher         = require("utils/EventDispatcher"),
+        viewUtils               = require("utils/ViewUtils"),


nit: ViewUtils, in ProperCase

ficristo · 2015-10-14T18:26:46Z

In the View menu, Toggle Panels menu doesn't show the shortcut.

@abose I briefly tested the patch and seems fine.
I agree with @petetnt for the panels.

abose · 2015-10-26T09:29:43Z

@zaggino There seems to be a bug. If you hide the git panel, the blue active icon for the git extension still remains in the main-toolbar. So added events when panels are shown or hidden so that extensions can listen to panel close events.

zaggino · 2015-10-26T09:59:25Z

thanks for the info @abose

petetnt · 2015-10-27T09:08:28Z

Tested this out again against 51c0232 , love the No distractions mode.

There's a small issue with toggle panels though (other than the shortcut not showing up/working)

Open foo.js
Create a validation error (I am using brackets-eslint)
Click Toggle Panels -> nothing happens (expected: panel closes)
Click Toggle Panels -> panel closes.

That issue that affects brackets-git affects other Extensions too, such as brackets-todo. Is there a way to (at least temporarily / during 1.6.) to throw a warning if panel was closed but the button state remained + link to say Brackets-Wiki where those events would be explained). That would provide a easy way for extension makers that use panels to know that they should update their extensions).

ryanstewart · 2015-11-09T23:01:56Z

Looks good to me. And agree, that the no distraction mode is a nice touch.

Do we have an idea of how often people will want to jump into this? Main question is wether we can set an easier shortcut.

I also like that it doesn't go full screen the way Sublime Text does, but any thought about whether we need that?

petetnt · 2015-11-10T06:34:46Z

@ryanstewart there was an issue about "true" fullscreen some while ago (#11594) and when checking out that one I saw that CEF got updated to support fullscreen quite recently so it could be implemented relatively easily (needs a brackets-shell update though) separate from this feature. 👍

ryanstewart · 2015-11-10T07:29:30Z

@petetnt ahh, awesome. And I'm definitely not advocating for that, just wanted to throw it out there. Sounds like it's been covered though!

abose · 2015-11-17T15:53:30Z

ctrl+shift+~ falls in the same vertical last line in the keyboard, so i thought it would be easily accesible to dismiss panels with one hand.

abose · 2015-11-17T16:36:42Z

@petetnt i have created #11924
This is an issue in extract extension too.

nethip · 2015-11-18T10:23:46Z

src/extensions/default/NoDistractions/main.js

@@ -0,0 +1,155 @@
+/*
+ * Copyright (c) 2013 Adobe Systems Incorporated. All rights reserved.


Change copyright from 2013 to 2015

nethip · 2015-11-18T12:13:42Z

Couple of quick comments.

We need to add unit tests for the new No Distraction feature. I saw some changes in the unit tests but I am not sure if they are going to cover the new workflows
We need to add health logs for the new functionality. Also make sure to update our Health Data wiki with this new data
It is better to have null checks at places where we calling APIs, as we would never know if the API returns an actual value or null. If you want to catch errors here, use a null check along with console.warn/console.error. That should raise errors in the console, in case of failures
Please update the documentation, wherever required
Make sure we update our API docs with the changes/additions

Overall it looks good 👍 It is good to merge, provided the review comments are addressed.

abose · 2015-11-18T12:45:31Z

@nethip thanks for reviewing. Made the changes.
Will add unit tests soon.

nethip · 2015-11-18T18:36:26Z

@abose No problem :) I took the liberty to add unit tests checkbox to your first comment. Also I created a waffle card for tracking the unit tests for this feature I am going ahead merging this.

Thanks for this feature @abose !

Toggle panels and no-Distraction mode

seehup · 2018-10-05T20:43:47Z

Comment on pull request

seehup · 2018-10-05T20:44:12Z

Comment on pull request

Show or hide sidebar

03cabf9

abose added this to the Release 1.6 milestone Sep 23, 2015

abose added the F General UI label Sep 23, 2015

abose added 5 commits September 24, 2015 11:55

Fix unit test failures.

cc58f2f

Fix grunt test failures as viewUtils had dependencies into brackets c…

c93797e

…ore which cannot be satisfied in build tests.

Moving everything to an extension

9a7f78a

Renaming pure code to No Distractions

5495170

No distraction mode now toggles all open panels too

e2868de

abose mentioned this pull request Oct 1, 2015

shortcut to hide panels, e.g. search #11764

Open

abose changed the title ~~no-Distraction mode~~ Toggle panels and no-Distraction mode Oct 7, 2015

abose added 2 commits October 7, 2015 16:13

Added toggle panels and shortcut

60e273d

fix lint error

df9c632

petetnt reviewed Oct 12, 2015
View reviewed changes

Review comments, and toggle panel only if workspace has not changed a…

a1a6573

…fter a hide panels command is issued.

ficristo reviewed Oct 14, 2015
View reviewed changes

Code cleanup, raising events when panel is shown/hidden.

51c0232

nethip reviewed Nov 18, 2015
View reviewed changes

abose added 2 commits November 18, 2015 18:22

review comments et.al.

1968da5

Health data Logs

d35ebb0

nethip added a commit that referenced this pull request Nov 18, 2015

Merge pull request #11732 from adobe/abose/noDistractions

3cec328

Toggle panels and no-Distraction mode

nethip merged commit 3cec328 into master Nov 18, 2015

marcelgerber deleted the abose/noDistractions branch May 23, 2016 07:58

This was referenced Aug 30, 2021

[CLOSED] Toggle panels and no-Distraction mode brackets-archive/bracketsIssues#10155

Open

shortcut to hide panels, e.g. search brackets-archive/bracketsIssues#13395

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Toggle panels and no-Distraction mode #11732

Toggle panels and no-Distraction mode #11732

abose commented Sep 23, 2015

abose commented Oct 8, 2015

abose commented Oct 12, 2015

petetnt Oct 12, 2015

petetnt commented Oct 12, 2015

petetnt Oct 12, 2015

abose commented Oct 13, 2015

ficristo Oct 14, 2015

ficristo commented Oct 14, 2015

abose commented Oct 26, 2015

zaggino commented Oct 26, 2015

petetnt commented Oct 27, 2015

ryanstewart commented Nov 9, 2015

petetnt commented Nov 10, 2015

ryanstewart commented Nov 10, 2015

abose commented Nov 17, 2015

abose commented Nov 17, 2015

nethip Nov 18, 2015

nethip commented Nov 18, 2015

abose commented Nov 18, 2015

nethip commented Nov 18, 2015

seehup commented Oct 5, 2018

seehup commented Oct 5, 2018

		@@ -0,0 +1,155 @@
		/*
		* Copyright (c) 2013 Adobe Systems Incorporated. All rights reserved.

Toggle panels and no-Distraction mode #11732

Toggle panels and no-Distraction mode #11732

Conversation

abose commented Sep 23, 2015

abose commented Oct 8, 2015

abose commented Oct 12, 2015

petetnt Oct 12, 2015

Choose a reason for hiding this comment

petetnt commented Oct 12, 2015

petetnt Oct 12, 2015

Choose a reason for hiding this comment

abose commented Oct 13, 2015

ficristo Oct 14, 2015

Choose a reason for hiding this comment

ficristo commented Oct 14, 2015

abose commented Oct 26, 2015

zaggino commented Oct 26, 2015

petetnt commented Oct 27, 2015

ryanstewart commented Nov 9, 2015

petetnt commented Nov 10, 2015

ryanstewart commented Nov 10, 2015

abose commented Nov 17, 2015

abose commented Nov 17, 2015

nethip Nov 18, 2015

Choose a reason for hiding this comment

nethip commented Nov 18, 2015

abose commented Nov 18, 2015

nethip commented Nov 18, 2015

seehup commented Oct 5, 2018

seehup commented Oct 5, 2018