This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Show an error message when trying to rename a file outside of the project #12234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGMT 👍 |
| errString = Strings.ERROR_RENAMING_NOT_IN_PROJECT; | ||
| } else { | ||
| errString = FileUtils.getFileErrorString(errorInfo.type); | ||
| } |
There was a problem hiding this comment.
Perhaps it would be better to organize the entire decision tree as a switch (including line 1323).
|
Thanks @marcelgerber . I have made pushed a minor change to this PR to use |
|
Thanks @abose. I'm mostly busy doing other stuff right now, so I greatly appreciate your effort! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9650.
Renaming files outside of the project has never worked (see also #6896), but until now, we have just (more or less) no-oped in that case, leaving the user clueless on why the rename operation failed.
I think this is a better approach.