This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix unit tests when run from symlinked directory #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +81,7 @@ define(function (require, exports, module) { | |||
| } | |||
|
|
|||
| // This returns path to test folder, so convert to src | |||
| bracketsPath = bracketsPath.replace("brackets/test", "brackets/src"); | |||
| bracketsPath = bracketsPath.replace("/test", "/src"); | |||
There was a problem hiding this comment.
Seems like we should make this an anchored regexp (assuming /test should be at the end of the path). Otherwise if you were a user whose username started with "tester", for example, this might not work.
ghost
assigned 
|
Reviewing |
|
Looks good, merging. |
njx
pushed a commit
that referenced
this pull request
Sep 7, 2012
Fix unit tests when run from symlinked directory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes to the dev environment setup, there is no guarantee that our root folder is named "brackets". This updates the unit test runner accordingly.