"Show in Tree" command #1823
"Show in Tree" command #1823
Conversation
peterflynn
commented
Oct 12, 2012
peterflynn
commented
- General purpose ProjectManager.showInTree() API (any file/folder)
- "Show in Tree" command (current file)
- Utility for searching arrays (new CollectionUtils module): used in new code plus to clean up an older DocumentManager method
- General purpose showInTree() API (any file/folder) - "Show in Tree" command (current file) - Utility for searching arrays (new CollectionUtils module): used in new code plus cleans up a DocumentManager method
ghost
assigned 
| @@ -195,6 +195,7 @@ define({ | |||
| "CMD_QUICK_EDIT_NEXT_MATCH" : "Next Match", | |||
| "CMD_NEXT_DOC" : "Next Document", | |||
| "CMD_PREV_DOC" : "Previous Document", | |||
| "CMD_SHOW_IN_TREE" : "Show in Tree", | |||
There was a problem hiding this comment.
This seems a little generic. Maybe "Show in Project Tree" or "Show in Project Panel"?
|
Nice work! Done with initial review. |
- Fix bug in _findTreeNode(): return rejected Promise instead of null when path lies outside project tree
|
Fixes pushed. NJ suggested "Show in File Tree," so I went with that and renamed the command accordingly since that was named equally generically. I also realized that the "file not within project" case should also be returning the Promise, so I fixed that and only moved treeAPI lower down. |
|
Looks good. Merging. |
|
"Show in File Tree" seems to be a something you have to go to over and over. Is there a way to make it a toggle, so it's always on if you want that way. Currently, the highlighting switching to the "Working Files", so it's no longer "in File Tree". To get it back there, you have to manually go to Navigate->Show in File Tree. |
