This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix for #1886 #1897
Merged
Fix for #1886 #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -500,8 +500,8 @@ define(function LiveDevelopment(require, exports, module) { | |||
| } | |||
|
|
|||
| /** Triggered by a document saved from the DocumentManager */ | |||
| function _onDocumentSaved() { | |||
| var doc = _getCurrentDocument(); | |||
| function _onDocumentSaved(event, data) { | |||
There was a problem hiding this comment.
Why don't we just use the document passed in the event since DocumentManager always passes it in?
You can simply replace "data" with "doc" and then remove the next line.
There was a problem hiding this comment.
Sure, I can make that change. Just thought I would make this "backwards compatible", but if it's only triggered from one place then it won't matter.
|
Looks good! Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of the browser refresh in #1886 is that
_onDocumentSaved()thinks the Document being saved is an HTML Document, so an HTML live reload is triggered. But in reality, the Document being saved is a CSS Document in an inline editor.Previously the
_onDocumentSaved()method assumed that the Document being saved was the one returned by_getCurrentDocument(). In the case when an inline editor's Document is saved,_getCurrentDocument()returns the Document of the primary editor instead of the inline editor.The actual saved Document is passed along when the
documentSavedevent is triggered inDocument.prototype.notifySaved():We just needed to accept the event data into
_onDocumentSaved()and utilize it to determine the saved Document.Note: An alternative solution would be to change the behavior of
_getCurrentDocument()so that it returns the inline editor's Document, but I'm assuming we always want that to return the primary Document.