Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix issue #1916 - Menu Name Inconsistency #1928

Merged
merged 4 commits into from
Oct 30, 2012
Merged

Fix issue #1916 - Menu Name Inconsistency #1928

merged 4 commits into from
Oct 30, 2012

Conversation

KraigWalker
Copy link
Contributor

issue #1916

Minor Fix - Modified text for ''Delete/Move Lines" to use standard English
pluralization as opposed to "(s)"

Modified text for ''Delete/Move Lines" to use standard English
pluralization as opposed to "(s)"
@peterflynn
Copy link
Member

@KraigWalker: could you also update the "CMD_COMMENT" string, per the bug? I like the second form: "Toggle Line Comment."

@KraigWalker
Copy link
Contributor Author

is there an issue relating to that? I can check that out in the root strings anyway though.

@njx
Copy link

njx commented Oct 25, 2012

Looks like it was mentioned in the original bug description for #1916.

@njx
Copy link

njx commented Oct 29, 2012

Thanks for the update--will review today.

@peterflynn
Copy link
Member

@KraigWalker: I think we'd actually prefer to name it "Toggle Line Comment" as mentioned in the bug (#1916).

@njx
Copy link

njx commented Oct 30, 2012

Looks good--thanks for deal with all our nitpicking :) Merging.

njx pushed a commit that referenced this pull request Oct 30, 2012
Fix issue #1916 - Menu Name Inconsistency
@njx njx merged commit be315cf into adobe:master Oct 30, 2012
@njx
Copy link

njx commented Oct 30, 2012

@KraigWalker -- oops, I forgot to ask if you signed our CLA. Could you go ahead and do that? (You only need to do it this one time--it's good for all future submissions.) http://dev.brackets.io/brackets-contributor-license-agreement.html

@KraigWalker
Copy link
Contributor Author

Signed, sealed delivered!

On 30 Oct 2012, at 02:54, Narciso Jaramillo notifications@github.com wrote:

@KraigWalker -- oops, I forgot to ask if you signed our CLA. Could you go ahead and do that? (You only need to do it this one time--it's good for all future submissions.) http://dev.brackets.io/brackets-contributor-license-agreement.html


Reply to this email directly or view it on GitHub.

http://www.kraigwalker.com

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants