This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Ctrl-L to select line #2002
Merged
Ctrl-L to select line #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Assigning to @peterflynn |
| @@ -148,6 +148,7 @@ define({ | |||
| // Edit menu commands | |||
| "EDIT_MENU" : "Edit", | |||
| "CMD_SELECT_ALL" : "Select All", | |||
| "CMD_SELECT_ALL" : "Select Line", | |||
There was a problem hiding this comment.
Copy-paste error: the key should be "CMD_SELECT_LINE"
| function selectLine() { | ||
| var editor = EditorManager.getFocusedEditor(); | ||
| if (editor) { | ||
| from = {line: editor.getSelection().start.line, ch: 0}, |
There was a problem hiding this comment.
Missing var keyword, so this will crash when you run it (due to strict mode)
|
Also needs a merge with master. |
|
Done reviewing |
| var editor = EditorManager.getFocusedEditor(); | ||
| if (editor) { | ||
| var from = {line: editor.getSelection().start.line, ch: 0}, | ||
| var to = {line: editor.getSelection().end.line + 1, ch: 0}; |
There was a problem hiding this comment.
Done. Also removed toggleUseTabChars()
There was a problem hiding this comment.
Syntax error again -- Brackets fails to start up because of this. Please correct the code, and test to make sure it runs before submitting the update.
|
My bad. I should've been careful. :) |
|
Alright, looks in good shape now -- merging. Thanks for finishing this off! |
peterflynn
added a commit
that referenced
this pull request
Nov 6, 2012
jasonsanjose
added a commit
that referenced
this pull request
Nov 7, 2012
Unit tests for new Select Line command (pull #2002)
peterflynn
added a commit
that referenced
this pull request
Nov 8, 2012
…s-scope * origin/master: (206 commits) Update 'de' locale Add cleanup bug number to TODO. Improve docs on Resizer. update recent projects extension. remove reference to settings button. encode the URLs Fix Menu.removeMenuItem() unit tests: update for new setup where all tests in spec share one window (use unique ids for everything). Code cleanup in removeMenuItem(): use existing utility method to compute menu item id. Plus some docs tweaks. also check status 0 Fix bug with Select Line around end of inline editor range, and add unit tests for it. Remove unused argument to highlightMatch() Fix edge case with string range reporting from stringMatch() trap status from XMLHttpRequest and fail accordingly Unit tests for new Select Line command (pull #2002) pass return value Comment formatting tweak per code review Fix Quick Open so discontiguous matches are highlighted in modes other than file search: - Hoist out generic highlightMatch() utility to generate bolded strings - Use it in both defaultResultsFormatter() and _filenameResultsFormatter() Also: - Clarify stringMatch() docs a bit - Fix an older glitch in basicMatchSort(): the sort field precedence list had a gap, leading to a no-op comparison step fix margin/padding in recent project drop down add Project Settings... item to file menu code review changes More focus bug fixes remove commented out code Tweaks to docs in various files: clarifications & added/fixed type annotations. Fix lots of JSLint errors in CSSUtils-test. Remove unused dependencies in WorkingSetView. ... Conflicts: src/command/Menus.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing as #1450 (comment)