Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Prevent reflow in the project name title (#1548) #2040

Merged
merged 2 commits into from
Nov 5, 2012
Merged

Prevent reflow in the project name title (#1548) #2040

merged 2 commits into from
Nov 5, 2012

Conversation

jbalsas
Copy link
Contributor

@jbalsas jbalsas commented Nov 4, 2012

This is a possible fix for Issue #1548

It uses the sidebar resize events to update the title width and prevent reflow by setting a fixed height and hidden overflow.

@ghost ghost assigned redmunds Nov 5, 2012
@redmunds
Copy link
Contributor

redmunds commented Nov 5, 2012

This looks good!

There's one other quirk that would be nice to also fix. Try opening a project folder that has breaking chars in the name (such as whitespace or hyphens) such as "Getting Started". As the side bar gets thinner, the word "Started" disappears all at once, but "Getting" displays as many characters as space allows. Can you try also applying "white-space: nowrap;" to the project name to prevent that?

@jbalsas
Copy link
Contributor Author

jbalsas commented Nov 5, 2012

@redmunds Nice catch! I've fixed that and also added some left margin to the settings icon to let it breathe a little...

One thing about this is that it only works when the RecentProjects extension is loaded. If extensions fail to load or RecentProjects would get disabled the title would reflow. Should we try a fix for that case as well?

@redmunds
Copy link
Contributor

redmunds commented Nov 5, 2012

I think it's ok that it only works with the recent-projects extension. I think it will be rare that anyone disables it.

Looks good. Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants