This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Clean up native menu item creation #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This looks good, but investigating Travis Error. |
|
Looks like exactly what we're seeing with the git clone failure. According to the comments, it's a Github issue. Not sure there's anything we can do about it besides creating a new pull request and maybe a new branch? The chain of events is weird since build #39 did pass but for some reason build #40 got kicked off but there were no following commits that would have triggered it. |
|
Travis is happy. Merging. |
redmunds
added a commit
that referenced
this pull request
Feb 1, 2013
Clean up native menu item creation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2615
Re-organize and simplify the creation of native menu items. This also has the side effect of setting the initial enabled and checked states for menu items.