This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Update StaticServerDomain unit tests #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t handled or was already handled.
ghost
assigned 
| waitsForDone(nodeConnection.domains.staticServer.closeServer(path), | ||
| "waiting for static server to close"); | ||
|
|
||
| waitsForDone(nodeConnection.domains.staticServer._setRequestFilterTimeout(), "restore request filter timeout"); |
There was a problem hiding this comment.
Should this be in a this.after() instead so that it always runs even if the test fails?
There was a problem hiding this comment.
Moved to afterEach instead. I tried to use this.after(), but nodeConnection is already null by that point since afterEach runs first.
|
Reviewed--looks good, just one note. |
|
Changes pushed. @njx ready to review |
|
Merging |
njx
pushed a commit
that referenced
this pull request
Apr 1, 2013
Update StaticServerDomain unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor unit tests. Add new tests for warnings when a response (1) is not handled or (2) was already handled.