This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Disallow leading dots #3437
Merged
Disallow leading dots #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
To @njx as this is part of the brackets-registry work. |
|
I guess the rewire guy uses IntellJ :) I filed a bug in his repo to remove the |
|
(Should we consider manually removing the |
|
Added all my comments on the second commit. Looks good with just those few nits--feel free to fix and merge. |
|
Nits fixed. Merging. |
peterflynn
added a commit
that referenced
this pull request
Apr 17, 2013
* origin/master: (28 commits) updated package validator based on comments in #3437 remove spurious IntelliJ files Updated by ALF automation. Another round of code review changes. Move HTML templates to htmlContent Tweaked dialog so it's centered a little better Renamed ExtensionMgr to ExtensionManager Code review fixes. Update comments to remove the Mustache note, since these can work with Handlebars too Make JSHint happy. Respond to review comments Initial extension manager dialog/view/model (with non-final layout) Move out hover preview menu item label to strings.js for localization. Remove unused variables and clean up some variable declarations. Merging Glenn's Hover Preview extension into core. Only allow leading numbers and letters (largely to prevent names like "..") import rewire to assist in testing Update Getting started screenshot for 'de' locale Fix DISALLOWED_WORDS placeholder in 'de' locale Updated by ALF automation. 'de' locale: Fix Travis build errors (duplicate strings), minor wording edits ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid names like ".." which could have security implications.
Note that the first commit is just importing rewire. The second commit is the relevant one for review.