This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Cleanup for comments from pull request #3439, switch to tern hinting #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update jsdoc use ExtensionUtils.getModulePath instead of manually slicing up path use FileUtils.readAsText instead of DocumentManager when we only need the text on disk Call CollectionUtils.hasProperty instead of Object.prototype.hasOwnProperty... Add comment explaining logic around finding location of called function for function type hinting remove unnecessary calls to setCursorPos remove stale comments in unittests pull out hint invalidation check into a function and remove check for query.length === 0, not necessary anymore
ghost
assigned 
|
Looks good! Merging. |
dangoor
added a commit
that referenced
this pull request
Apr 22, 2013
Cleanup for comments from pull request #3439, switch to tern hinting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixes for the minor issues discussed in #3439
Update jsdoc
use ExtensionUtils.getModulePath instead of manually slicing up path
use FileUtils.readAsText instead of DocumentManager when we only need the text on disk
Call CollectionUtils.hasProperty instead of Object.prototype.hasOwnProperty...
Add comment explaining logic around finding location of called function for function type hinting
remove unnecessary calls to setCursorPos
remove stale comments in unittests
pull out hint invalidation check into a function and remove check for query.length === 0, not necessary anymore