This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Position Hover Preview popover so it's not clipped #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Looks good and ready to land it in master, but waiting for @peterflynn #3531 to land first since he had already resolved two conflicts with his changes. |
| @@ -296,21 +297,17 @@ define(function (require, exports, module) { | |||
| runs(function () { | |||
|
|
|||
| // Issue #3447 - fixes both of the following tests | |||
There was a problem hiding this comment.
You need to add indentation to this comment line.
There was a problem hiding this comment.
I removed that comment.
|
Review changes pushed. |
|
@redmunds Once you resolve the conflict, I'll land it to master. |
|
@RaymondLim Conflicts resolved. |
RaymondLim
added a commit
that referenced
this pull request
Apr 23, 2013
Position Hover Preview popover so it's not clipped
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #3447. Unit Tests for this have been enabled.