Visual tweaks for the quick open drop-down.

[larz0]

@njx pls review.

[njx]

CSS comments use /* */. I'll push a fix for this if this is the only issue.

[redmunds]

LESS supports // style line comments. The difference is that /* */ style comments in a LESS file are maintained in the generated .css file, where // style comments are stripped.

[njx]

Oh, I had no idea. As Emily Litella would say, "Never mind."

[njx]

Hey--I like removing the separators, but there's some concern that it seems a bit hard to distinguish the individual list items from each other--it's a bit of a sea of text. A couple of things I tried:

• lightening the path strings to #aaa - that helped, but made the paths a little too hard to read, and they're important when you have the same filename in multiple paths, like main.js or strings.js
• adding a very light gray background (e.g. #f6f6f6) to even-numbered items - this made them stand out a bit too much

Would it be appropriate to make the background gray and add striping similar to your mockup for the Find in Files results? There the striping seems to work well without making either the lighter or darker rows stand out too much.

(BTW, I don't think we want to fix this by adding more padding between the items...want to keep the information density we have now.)

[larz0]

np I'll give that a go.

[larz0]

Updated the branch.

[jasonsanjose]

I like the new look a lot! My only concern is that the selected color doesn't stand out enough.

[adrocknaphobia]

I'm OK with the subdued selected color. The selection is interaction based (moving the arrow keys or hovering w/ a mouse). So the movement and interaction draw your attention to the highlight. If there was no movement then I'd agree w/ @jasonsanjose, but I think it works here.

[peterflynn]

This should use @font-weight-semibold

[peterflynn]

This should use @font-weight-semibold

[peterflynn]

Re removing the scroller shadow: what about when there's a ModalBar open at the top (e.g. Find)? Or a permanent menu bar (in inBrowser mode)? Do we still need a shadow for it to look good in those cases?

[larz0]

@peterflynn ModalBars always sits on top of content so it will always have a shadow, so now only CSS is being used instead of JS. How do I go into inBrowser mode?

[peterflynn]

Oh, I didn't see that you'd added a fixed shadow to ModalBar -- great! That same rule also covers inBrowser mode (that's what #titlebar is), so I think you're all set.

[njx]

@larz0 - I think we ended up still having concerns about the selection highlight being too subtle. The issue is that (because of the way our widget works currently) you might start off with something other than the topmost item being highlighted (because if the mouse happens to be over the list when it opens up, the item underneath it gets selected even if you don't click on it). This probably isn't ideal, but fixing it would be difficult until we get a better widget implementation.

So, it would be better if we could have a slightly colored highlight that was easier to see immediately against the striped items.

[larz0]

No problem, try it now.

[njx]

Looks good--I merged it manually with master since there was a recent conflict.