-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Issue #3679 - File extension now dimmed if created via File > New #3690
Conversation
call() performance twice as better than apply() http://jsperf.com/call-apply-segu
On creation of a file item, make sure we use ViewUtils.getFileEntryDisplay() to set the right extension styles.
How often does pull requests get merged ? |
Assign to myself @rajeshsegu Pull requests are usually merged during one or two sprint periods tops. We've fallen a little bit behind since the team's been focusing on important core features for the last sprints, but we should pick it up soon. In fact, I'll review this one today ;) |
@rajeshsegu Before we can accept this we'll need you to sign our CLA. You only need to do this once here http://dev.brackets.io/brackets-contributor-license-agreement.html |
Done. |
@rajeshsegu Thanks for taking this one! Changes look good! It seems that a commit from #3687 got leaked to this pull request. I guess you created this branch from master after that commit was already there. You should create separate branches before starting to work on separate issues in order to avoid that. Otherwise, you'd need to hold off any work until your previous requests get merged. If you plan to work further on #3669, I'd suggest you to try and rebase this branch to remove that commit so that we won't be merging any additional code in here. Otherwise, we may take this one as is and just close #3687, but I'd rather keep things separated. |
@rajeshsegu You forgot to add the "I'd rather keep things separated" when quoting me ;) I'll go ahead and merge this since it's a very small change that we want in anyway, but please, make sure to keep things separated in the future. Thanks for start contributing! Hope to see more coming ;) |
Issue #3679 - File extension now dimmed if created via File > New
Looks like the createNewItem() method never used "set_text" on successCallback of creating a new file item.