Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Issue #3679 - File extension now dimmed if created via File > New #3690

Merged
merged 2 commits into from
May 3, 2013

Conversation

rajeshsegu
Copy link

Looks like the createNewItem() method never used "set_text" on successCallback of creating a new file item.

rsegu added 2 commits April 30, 2013 22:15
call() performance twice as better than apply()

http://jsperf.com/call-apply-segu
On creation of a file item, make sure we use
ViewUtils.getFileEntryDisplay() to set the right extension styles.
@rajeshsegu
Copy link
Author

How often does pull requests get merged ?

@ghost ghost assigned jbalsas May 2, 2013
@jbalsas
Copy link
Contributor

jbalsas commented May 2, 2013

Assign to myself

@rajeshsegu Pull requests are usually merged during one or two sprint periods tops. We've fallen a little bit behind since the team's been focusing on important core features for the last sprints, but we should pick it up soon. In fact, I'll review this one today ;)

@jbalsas
Copy link
Contributor

jbalsas commented May 2, 2013

@rajeshsegu Before we can accept this we'll need you to sign our CLA. You only need to do this once here http://dev.brackets.io/brackets-contributor-license-agreement.html

@rajeshsegu
Copy link
Author

Done.

@jbalsas
Copy link
Contributor

jbalsas commented May 2, 2013

@rajeshsegu Thanks for taking this one! Changes look good!

It seems that a commit from #3687 got leaked to this pull request. I guess you created this branch from master after that commit was already there. You should create separate branches before starting to work on separate issues in order to avoid that. Otherwise, you'd need to hold off any work until your previous requests get merged.

If you plan to work further on #3669, I'd suggest you to try and rebase this branch to remove that commit so that we won't be merging any additional code in here. Otherwise, we may take this one as is and just close #3687, but I'd rather keep things separated.

@rajeshsegu
Copy link
Author

@jbalsas rebasing and making the changes again should be easy, but if you can accomodate the below option, I would be happy. Next time I will make sure I submit changes using a branch.

"Otherwise, we may take this one as is and just close #3687."

@jbalsas
Copy link
Contributor

jbalsas commented May 3, 2013

@rajeshsegu You forgot to add the "I'd rather keep things separated" when quoting me ;)

I'll go ahead and merge this since it's a very small change that we want in anyway, but please, make sure to keep things separated in the future.

Thanks for start contributing! Hope to see more coming ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants