Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix #4091: Order of OK and Cancel buttons is reversed #4113

Merged
merged 2 commits into from
Jun 6, 2013
Merged

Fix #4091: Order of OK and Cancel buttons is reversed #4113

merged 2 commits into from
Jun 6, 2013

Conversation

TomMalbran
Copy link
Contributor

This requests fix the inverted order of the buttons on the Install From Url Dialog and the margin between the right buttons on some dialogs, which should fix the issues I mention in #4091. Let me know if there is something else to fix for that issue.

@redmunds
Copy link
Contributor

redmunds commented Jun 6, 2013

This fixes the gap between the buttons, but the button order of modal dialogs is still not correct.

Recipe 1
Open the Project Settings dialog (File > Project Settings...). Notice the OK button is on the left of the Cancel button. In Sprint 25 it's on the right.

Recipe 2
Open any file, make an edit, do not save, close the file. In the dialog that prompts to save, the Save button is on the left of the Cancel button. In Sprint 25, the Save button is on the right.

Note that the Project Settings dialog uses the standard modal dialog, so these are most likely the same fix.

@TomMalbran
Copy link
Contributor Author

The order of the buttons was switch on purpose for windows only in the request #3086 to fix the issue #1089.

@redmunds
Copy link
Contributor

redmunds commented Jun 6, 2013

Really? Nevermind. :)

@ghost ghost assigned jasonsanjose Jun 6, 2013
@jasonsanjose
Copy link
Member

Reviewing

@jasonsanjose
Copy link
Member

Merging. Thanks @TomMalbran!

jasonsanjose added a commit that referenced this pull request Jun 6, 2013
Fix #4091: Order of OK and Cancel buttons is reversed
@jasonsanjose jasonsanjose merged commit 3d56039 into adobe:master Jun 6, 2013
@TomMalbran TomMalbran deleted the tom/issue-4091 branch July 23, 2013 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants