This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Add support for W3 Gradients in QuickView #4261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -175,7 +175,7 @@ define(function (require, exports, module) { | |||
|
|
|||
| // Check for gradient. -webkit-gradient() can have parens in parameters | |||
| // nested 2 levels. Other gradients can only nest 1 level. | |||
| var gradientRegEx = /-webkit-gradient\((?:[^\(]*?(?:\((?:[^\(]*?(?:\([^\)]*?\))*?)*?\))*?)*?\)|(?:(?:-moz-|-ms-|-o-|-webkit-|\s)(linear-gradient)|(?:-moz-|-ms-|-o-|-webkit-)(radial-gradient))(\((?:[^\)]*?(?:\([^\)]*?\))*?)*?\))/gi, | |||
| var gradientRegEx = /-webkit-gradient\((?:[^\(]*?(?:\((?:[^\(]*?(?:\([^\)]*?\))*?)*?\))*?)*?\)|(?:(?:-moz-|-ms-|-o-|-webkit-|\s)((repeating-)?linear-gradient)|(?:-moz-|-ms-|-o-|-webkit-|\s)((repeating-)?radial-gradient))(\((?:[^\)]*?(?:\([^\)]*?\))*?)*?\))/gi, | |||
There was a problem hiding this comment.
The (repeating-)? expressions should use non-capturing parenthesis (?:repeating-)? so they are not added to the match array. We don't use that info, and then the array indexes won't need to be changed.
|
Done with review. Just 1 comment. Might want to squash the commits. |
|
closed in lieu of #4290 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CEF3.1453.1255 uses Chromium 27.0.1453.73. which has support for W3 and -web-kit tags for gradients. the W3 (or unprefixed) have a different syntax in some situations and are not compatible.
This pull request removes the incompatibility such that unprefixed tags are not given a -webkit- prefix and are previewed verbatim and the -moz-,-o-,-ms- tags are prefixed with -webkit- since their syntaxes are interchangeable but brackets' shell only displays -webkit- variants. .