This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Use DOM tree to debug browser against SimpleDOMBuilder #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inspector.html docs.
…ose/ResearchLiveHTML-debug Conflicts: src/language/HTMLInstrumentation.js
ghost
assigned 
| applyEditsPromise = RemoteAgent.call("applyDOMEdits", edits); | ||
|
|
||
| // compare in-memory vs. in-browser DOM | ||
| // set a conditional breakpoint at the top of this function: "this._debug = true, false" |
There was a problem hiding this comment.
Based on the comment, it seems like this is supposed to be conditional on a debug flag?
There was a problem hiding this comment.
Removing the comment.
|
Except for those couple of nits, this looks good. I initially couldn't get it to give me output, but that's because the example HTML I was using was too broken (bad things happen when there's no HTML tag). |
dangoor
added a commit
that referenced
this pull request
Aug 6, 2013
Use DOM tree to debug browser against SimpleDOMBuilder
jasonsanjose
added a commit
that referenced
this pull request
Aug 6, 2013
dangoor
added a commit
that referenced
this pull request
Aug 6, 2013
code review comments from #4658
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dangoor @njx
Runtime console warnings when in-editor DOM does not match in-browser DOM.
If there the browser DOM, does not match the in-editor DOM, the diffs are logged to the console. For example, there happens to be an in-browser issue with comments after the
<html>tag get reparented to the<body>tag. This results in the following console output:If the structures match, nothing is logged.
This change adds a new remote function
getSimpleDOM()that converts the actual DOM tree (the tree vs.outerHTMLfrom my previous implementation) into a JSON structure matching the tree built bySimpleDOMBuilder.We ignore some diffs including:
divhtmlelementDoes not handle in-browser DOM modifications yet.