This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Tab and modality fixes for the modal dialogs #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| /** | ||
| * @private | ||
| * Dismises a modal dialog | ||
| * @param {$.Element} dlg |
There was a problem hiding this comment.
Since dlg is a jQuery object, we should use $ prefix for the variable name. I know it's not your code, but you can clean it up for consistency with the way we name our variables.
update: You may need to check other functions in this module for changing dlg to $dlg.
| .css("z-index", zIndex + 1) | ||
| .next().css("z-index", zIndex); | ||
|
|
||
| zIndex += 2; |
There was a problem hiding this comment.
Nice implementation using z-index for nested dialogs.
|
Done with second review. Just have some comments and ready to merge if you're not going to change anything. |
|
Merging now. |
RaymondLim
added a commit
that referenced
this pull request
Aug 22, 2013
Tab and modality fixes for the modal dialogs
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request fixes the tab issue #4589 by refcusing the first/last input when we will tab outside the dialog.
And modal issue #4687, by handling the z-index of the dialogs and backdrops.
I also fixed several links missing the href attribute to make them tab-able and using space on those items to trigger the click event which was missing.