Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Provide Quick Docs for SCSS. #5069

Merged
merged 2 commits into from
Sep 5, 2013
Merged

Provide Quick Docs for SCSS. #5069

merged 2 commits into from
Sep 5, 2013

Conversation

RaymondLim
Copy link
Contributor

Just like providing CSS code hints for SCSS, we can also provide Quick Docs for SCSS since we already have the required code in CSSUtils.

@ghost ghost assigned redmunds Sep 5, 2013
@redmunds
Copy link
Contributor

redmunds commented Sep 5, 2013

I'll take this one

@@ -85,7 +85,8 @@ define(function (require, exports, module) {
*/
function inlineProvider(hostEditor, pos) {
// Only provide docs when cursor is in CSS content
if (hostEditor.getLanguageForSelection().getId() !== "css") {
if (hostEditor.getLanguageForSelection().getId() !== "css" &&
hostEditor.getLanguageForSelection().getId() !== "scss") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the value from hostEditor.getLanguageForSelection().getId() should be stored in a var since more modes will get added here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion!

@redmunds
Copy link
Contributor

redmunds commented Sep 5, 2013

Looks good. Just 1 comment.

… the same functions multiple times when checking it.
@redmunds
Copy link
Contributor

redmunds commented Sep 5, 2013

Merging.

redmunds added a commit that referenced this pull request Sep 5, 2013
@redmunds redmunds merged commit c07938f into master Sep 5, 2013
@redmunds redmunds deleted the rlim/quick-doc-for-scss branch September 5, 2013 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants