Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

czech language - sprint 30 #5127

Closed
wants to merge 1 commit into from
Closed

czech language - sprint 30 #5127

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 8, 2013

updated

@ghost ghost assigned njx Sep 9, 2013
@njx
Copy link
Contributor

njx commented Sep 10, 2013

Thanks @kvarel. @hansek, it looks like you've reviewed the Czech translation before--could you take a look? Thanks!

@@ -86,7 +86,7 @@ define({
"LIVE_DEV_SERVER_NOT_READY_MESSAGE" : "Chyba při spouštění HTTP serveru pro soubory živého náhledu. Prosím, zkuste to znovu.",
"LIVE_DEVELOPMENT_INFO_TITLE" : "Vítejte v živém náhledu!",
"LIVE_DEVELOPMENT_INFO_MESSAGE" : "Živý náhled připojí {APP_NAME} k vašemu prohlížeči. Spustí náhled HTML souboru, který se aktualizuje pokaždé, kdy editujete svůj kód.<br /><br />V této verzi {APP_NAME}, živý náhled funguje pouze v <strong>Google Chrome</strong> a aktualizuje změny v <strong>CSS souborech</strong>. Změny v HTML nebo JavaScript souborech jsou automaticky načteny, když soubor uložíte.<br /><br />(Tato zpráva se zobrazí pouze jednou.)",
"LIVE_DEVELOPMENT_TROUBLESHOOTING" : "Pro více informací navštivte <a href='{0}' title='{0}'>Troubleshooting Live Development connection errors</a>.",
"LIVE_DEVELOPMENT_TROUBLESHOOTING" : "Pro více informací navštivte <a href='#' class='clickable-link' data-href='{0}'>Troubleshooting Live Development connection errors</a>.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this string, so that the href has the actual url? Thanks.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kvarel As mentioned above, here should be definitely

<a href='{0}' title='{0}'>

as is in /src/nls/root/strings.js

@hansek
Copy link

hansek commented Sep 10, 2013

@njx Except previous inline comment/bug looks everything allright.

@njx njx mentioned this pull request Sep 10, 2013
@njx
Copy link
Contributor

njx commented Sep 10, 2013

Thanks @hansek and @TomMalbran. @kvarel could you make that fix? Also note #5142, which I don't think conflicts with yours--I'll merge it after merging this one.

@jasonsanjose
Copy link
Member

@kvarel if you have any trouble with git again just let us know. @njx in the past I've helped @kvarel by branching from his pull requests and making the fixes on my own.

@njx
Copy link
Contributor

njx commented Sep 23, 2013

I pt up #5312 which includes @kvarel's original commit and adds the fixes to the links. Closing this pull request. Thanks @kvarel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants