This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Don't reparse HTML files on save #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instrumented version with new IDs
gruehle
added a commit
that referenced
this pull request
Sep 20, 2013
Don't reparse HTML files on save
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5279.
Back when we wanted to reload HTML files in the browser on save, it made sense to fully rescan/reparse the document on save, since we were going to serve up a new version of the instrumented HTML. However, now that we no longer reload the HTML file, we don't want to reparse the doc, because that will generate new IDs which won't be reflected in the browser (since the browser will never request the reinstrumented HTML).
@gruehle
This is a pull request into the sprint-31-hotfix branch since we need to re-roll the official sprint 31 build. We will also merge that branch into master later.