This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Recent Projects - Pressing delete key removes project from list #5354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -202,6 +231,13 @@ define(function (require, exports, module) { | |||
| } | |||
| keyHandled = true; | |||
| break; | |||
| case KeyEvent.DOM_VK_BACK_SPACE: | |||
| case KeyEvent.DOM_VK_DELETE: | |||
| keyHandled = true; | |||
There was a problem hiding this comment.
shouldn't this be inside the if ($dropdownItem) { ... } ?
There was a problem hiding this comment.
I understand that keyHandled is indication that popup have something to do with this key. When user presses DELETE key while the project menu is open, user expects some action on the recent project menu itself and no where else. We should consider that.
There was a problem hiding this comment.
Yes but you want the key event to continue propagating if there is no $dropdownItem otherwise things stop working.
|
Looks good. Merging |
JeffryBooher
added a commit
that referenced
this pull request
Oct 21, 2013
Recent Projects - Pressing delete key removes project from list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5335