Menus.removeMenu cleanup: remove all menu items and dividers prior to removing menu #5384
Conversation
|
This fix makes sure that none of the menu items and dividers on the menu being removed are orphaned. It is the final piece of functionality I need (hopefully) to implement a solution for issue #5078. |
ghost
assigned 
|
@lkcampbell Thanks for taking care of all the necessary changes for issue #5078. Unfortunately, I won't be able to review and merge this for sprint 32. Will review it when sprint 33 starts on next week. |
|
@RaymondLim, if you get some time to commit this pull request this week or early next week, I have the time to submit the "Reload without user extension" pull request next week. That way, we might be able to get the feature in for Sprint 33. |
| @@ -877,6 +929,9 @@ define(function (require, exports, module) { | |||
| * Extensions should use the following format: "author.myextension.mymenuname". | |||
| */ | |||
| function removeMenu(id) { | |||
| var menu, | |||
| commandID = ""; | |||
There was a problem hiding this comment.
Minor nit: Please remove those extra spaces before =.
|
@lkcampbell |
|
@RaymondLim, changes for code review done. |
Menus.removeMenu cleanup: remove all menu items and dividers prior to removing menu
No description provided.