This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix #5537: Start live development even if there is no open file #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@dangoor Can you please test this to see if it's the expected behaviour? |
|
@SAplayer Yes, this appears to behave as I was hoping for. @ingorichter will do the review, because he's familiar with the code from his recent work allowing you to start live development from CSS files. |
ingorichter
added a commit
that referenced
this pull request
Oct 24, 2013
Fix #5537: Start live development even if there is no open file
|
@SAplayer Thanks! |
| }; | ||
|
|
||
| while (!indexFileFound && stillInProjectTree) { | ||
| i = CollectionUtils.indexOf(filteredFiltered, filterIndexFile); |
There was a problem hiding this comment.
Drive-by, after-the-fact comment: CollectionUtils.indexOf is deprecated.
There was a problem hiding this comment.
Was there before ;) Not my fault
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #5537 where you can't start Live Development if there is no open file even if there is an index.html in it.
It works, but please check to code to decide whether this is a good solution/fix or just a bad workaround.
The LiveDev tests ran fine, I haven't tested any others.