Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix sv Node translation #5647

Merged
merged 2 commits into from
Oct 24, 2013
Merged

Fix sv Node translation #5647

merged 2 commits into from
Oct 24, 2013

Conversation

micole
Copy link
Contributor

@micole micole commented Oct 23, 2013

This is for issue #5603

@micole
Copy link
Contributor Author

micole commented Oct 23, 2013

Sorry about that, this is for issue #5603.

@redmunds
Copy link
Contributor

I updated title which should describe what pull request does (not just an issue number). Put issue references in description so they are auto-linked.

Also note that if you use the word "fixes" near an issue reference, the issue gets auto-closed when pull request is merged, which is not always desired.

@micole
Copy link
Contributor Author

micole commented Oct 23, 2013

@redmunds Oh, I wasn't aware that "fixes" caused that to happen. I can close this and try to resubmit if that is prefered.

@micole
Copy link
Contributor Author

micole commented Oct 23, 2013

@redmunds Changed the commit message to not "fix"

@redmunds
Copy link
Contributor

@micole I believe it's using "fix" (or some form of) in the pull requests comments (not the commit message) that triggers the auto-close behavior. Just letting you know -- no need to close PR.

@ghost ghost assigned jasonsanjose Oct 23, 2013
@jasonsanjose
Copy link
Member

@mikaeljorhult or @jackbillstrom can you review these minor changes to the Swedish translation?

@ghost ghost assigned jasonsanjose Oct 23, 2013
@mikaeljorhult
Copy link
Contributor

It needs a couple of small tweaks (see line comments).

@jasonsanjose
Copy link
Member

Thanks @mikaeljorhult! @micole please update your pull request.

@redmunds can you take over here while I'm on vacation?

@micole
Copy link
Contributor Author

micole commented Oct 23, 2013

@jasonsanjose, @redmunds would you prefer for me to make the 2 commits into 1?

@redmunds
Copy link
Contributor

@jasonsanjose Sure. @couzteau has also been helping out with translations.

@jasonsanjose
Copy link
Member

@micole not necessary, 2 commits is fine.

@micole
Copy link
Contributor Author

micole commented Oct 24, 2013

@redmunds This should be ready to be pulled in whenever you are ready.

redmunds added a commit that referenced this pull request Oct 24, 2013
@redmunds redmunds merged commit 6864ff9 into adobe:master Oct 24, 2013
@redmunds
Copy link
Contributor

Merged. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants