-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
Sorry about that, this is for issue #5603. |
I updated title which should describe what pull request does (not just an issue number). Put issue references in description so they are auto-linked. Also note that if you use the word "fixes" near an issue reference, the issue gets auto-closed when pull request is merged, which is not always desired. |
@redmunds Oh, I wasn't aware that "fixes" caused that to happen. I can close this and try to resubmit if that is prefered. |
@redmunds Changed the commit message to not "fix" |
@micole I believe it's using "fix" (or some form of) in the pull requests comments (not the commit message) that triggers the auto-close behavior. Just letting you know -- no need to close PR. |
@mikaeljorhult or @jackbillstrom can you review these minor changes to the Swedish translation? |
It needs a couple of small tweaks (see line comments). |
Thanks @mikaeljorhult! @micole please update your pull request. @redmunds can you take over here while I'm on vacation? |
@jasonsanjose, @redmunds would you prefer for me to make the 2 commits into 1? |
@jasonsanjose Sure. @couzteau has also been helping out with translations. |
@micole not necessary, 2 commits is fine. |
@redmunds This should be ready to be pulled in whenever you are ready. |
Merged. Thanks. |
This is for issue #5603