This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix issues with updating inline editor when not visible #5899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // called back right away. (The animation would happen later when we switch | ||
| // back to the editor.) | ||
| if (self.isFullyVisible()) { | ||
| console.log("animating removal"); |
There was a problem hiding this comment.
This should be removed, shouldn't it?
ghost
assigned 
| self._codeMirror.removeLineWidget(inlineWidget.info); | ||
| self._removeInlineWidgetInternal(inlineWidget); | ||
| deferred.resolve(); | ||
| } |
There was a problem hiding this comment.
Same comment again, this time in the pull request:
JSLint error on this line: Unexpected '(space)'.
|
Done with review. Just 1 JSLint error. |
|
Fixed JSLint error, ready for re-review |
|
Merging. |
redmunds
added a commit
that referenced
this pull request
Nov 9, 2013
Fix issues with updating inline editor when not visible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the two issues mentioned in #5643 (the main bug and the one I noted in the comment). Note that to reproduce the original issue, you have to have at least three rules in the inline editor.
Note also that #5896 isn't caused by this pull request (it reproduces in sprint 33).