Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

A couple of Fixes for PR #6107 #7085

Merged
merged 2 commits into from
Mar 5, 2014
Merged

A couple of Fixes for PR #6107 #7085

merged 2 commits into from
Mar 5, 2014

Conversation

TomMalbran
Copy link
Contributor

This fixes 2 issues after PR #6107, which don't let you open the recent projects menu by clicking on it or using Ctrl+Alt+R

@JeffryBooher Since he did the original PR review.

@artoale
Copy link
Contributor

artoale commented Mar 5, 2014

Yup! I wasn't even aware of the Cmd-Alt-R shorcut :)
Maybe add a regression test for this too?

@ingorichter
Copy link
Contributor

Yes, a regression test would be great.

@ingorichter ingorichter self-assigned this Mar 5, 2014
@TomMalbran
Copy link
Contributor Author

The Recent Projects extension currently has no tests

@ingorichter
Copy link
Contributor

@TomMalbran We should change this. I'll create an issue to track this. But for now I'm going to merge the PR to get this feature working again.

ingorichter added a commit that referenced this pull request Mar 5, 2014
@ingorichter ingorichter merged commit bbd5a2a into master Mar 5, 2014
@TomMalbran
Copy link
Contributor Author

Sure the test could be part of a new Issue, which would be harder to do since there are none.

@TomMalbran TomMalbran deleted the tom/fix-after-pr6107 branch March 5, 2014 07:11
@ingorichter
Copy link
Contributor

Added #7087 to track the addition of unit tests for the Recent Projects Extension.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants