This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Added filename validation for Mac #7377
Closed
Closed
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e49dc71
Added filename validation for Mac
thomastaylor312 bbd64d8
Updated to not use a RegExp object and removed unneeded characters fr…
thomastaylor312 eac7228
Added checkForValidFilename method to the FileUtils and updated the i…
thomastaylor312 599aaf3
Cleaned up regex's in the checkForValidFilename method.
thomastaylor312 88f5d4f
Actually combined the Mac and Linux invalid chars logic this time.
thomastaylor312 3fd2d0b
Updated checkForValidFilename to only require a filename and moved th…
thomastaylor312 34a1708
Created new method for showing a dialog box for invalid filenames and…
thomastaylor312 437da33
Merge branch 'master' into Issue-7326. Also changed unit test to refl…
thomastaylor312 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2287,7 +2287,7 @@ define(function (require, exports, module) { | |
|
||
// Init invalid characters string | ||
if (brackets.platform === "mac") { | ||
_invalidChars = "?*|:"; | ||
_invalidChars = "/?:*"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We also shouldn't allow the vertical bar |
||
} else if (brackets.platform === "linux") { | ||
_invalidChars = "?*|/"; | ||
} else { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move the
_checkForValidFilename
from ProjectManager.js to FileUtils.js and then call it from both places since this is basically doing the same thing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually was about to ask that. I'll do that tonight and push it tonight or tomorrow.